Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make windows docs for signal module show up on unix builds #3770

Merged
merged 7 commits into from
Aug 2, 2021

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented May 9, 2021

This PR moves most of the windows implementation for signal into a new tokio/src/signal/windows/os_impl.rs file, leaving the tokio/src/signal/windows.rs file with only definitions of the public types. This makes the documentation show up when building on unix.

@Darksonn Darksonn added T-docs Topic: documentation A-tokio Area: The main tokio crate M-signal Module: tokio/signal labels May 9, 2021
@Darksonn
Copy link
Contributor Author

Darksonn commented May 9, 2021

Oh, I didn't notice that #3768 was a PR. I thought it was an issue 😅

@udoprog
Copy link
Contributor

udoprog commented May 9, 2021

Oh, I didn't notice that #3768 was a PR. I thought it was an issue 😅

I see. I guess it's good that we both got a bit of experience doing this! I'll check this out and see if something can be done differently in the other PR at least.

@Darksonn Darksonn merged commit 69a6585 into master Aug 2, 2021
@Darksonn Darksonn deleted the signal-windows-docs branch August 2, 2021 18:55
@Darksonn Darksonn mentioned this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-signal Module: tokio/signal T-docs Topic: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants