stream: implement Error and Display for BroadcastStreamRecvError #3745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the tokio::sync::broadcast::error::RecvError instead.
Motivation
I want to use the broadcast stream wrapper in the situtaion where some codes requiring the custom Error implementing std::error:Error trair, such as wrap_stream() function in hyper crate.
Solution
We can add impl std::error::Error, and core::fmt::Display for
BroadcastStreamRecvError
, but since the custom error doesn't provide any additional info, so it's better removing it and reusing the existing error from broadcast channel.