Skip to content

docs: update docs for from_std functions#3016

Merged
Darksonn merged 1 commit intotokio-rs:masterfrom
zaharidichev:zd/tweak-from-std-docs
Oct 24, 2020
Merged

docs: update docs for from_std functions#3016
Darksonn merged 1 commit intotokio-rs:masterfrom
zaharidichev:zd/tweak-from-std-docs

Conversation

@zaharidichev
Copy link
Copy Markdown
Contributor

Fixes: #3007

Motivation

Some of the docs for from_std methods are outdated.

Solution

Update and unify docs.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-net Module: tokio/net T-docs Topic: documentation labels Oct 21, 2020
Comment on lines 167 to 168
/// This can be used in conjunction with net2's `UdpBuilder` interface to
/// configure a socket before it's handed off, such as setting options like
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it has to be part of this PR, but net2 is deprecated and this should also be updated as well.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #3034 to track this.

@Darksonn Darksonn merged commit ce173fd into tokio-rs:master Oct 24, 2020
mxinden added a commit to libp2p/rust-libp2p that referenced this pull request Nov 2, 2020
mxinden added a commit to libp2p/rust-libp2p that referenced this pull request Nov 2, 2020
mxinden added a commit to libp2p/rust-libp2p that referenced this pull request Nov 3, 2020
* Update tokio requirement from 0.2 to 0.3

Updates the requirements on [tokio](https://github.com/tokio-rs/tokio) to permit the latest version.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-0.2.0...tokio-0.3.0)

Signed-off-by: dependabot[bot] <support@github.com>

* protocols/mdns: Ensure to set non_blocking on tokio udp socket

* transports/tcp: Ensure to set non_blocking on tokio tcp socket

See tokio-rs/tokio#3016 for details.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Max Inden <mail@max-inden.de>
santos227 pushed a commit to santos227/rustlib that referenced this pull request Jun 20, 2022
* Update tokio requirement from 0.2 to 0.3

Updates the requirements on [tokio](https://github.com/tokio-rs/tokio) to permit the latest version.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-0.2.0...tokio-0.3.0)

Signed-off-by: dependabot[bot] <support@github.com>

* protocols/mdns: Ensure to set non_blocking on tokio udp socket

* transports/tcp: Ensure to set non_blocking on tokio tcp socket

See tokio-rs/tokio#3016 for details.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Max Inden <mail@max-inden.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tokio Area: The main tokio crate M-net Module: tokio/net T-docs Topic: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify correctness of all from_std functions

3 participants