Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable clippy lints #1335

Merged
merged 25 commits into from
Jul 25, 2019
Merged

ci: enable clippy lints #1335

merged 25 commits into from
Jul 25, 2019

Commits on Jul 21, 2019

  1. ci: enable clippy lints

    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    d464253 View commit details
    Browse the repository at this point in the history

  2. Allow some clippy warnings 

    * clippy::mut_from_ref
* clippy::map_clone
* clippy::should_implement_trait
* clippy::transmute_ptr_to_ptr
* clippy::trivially_copy_pass_by_ref
* clippy::type_complexity
* clippy::module_inception
* clippy::wrong_self_convention
* clippy::mutex_atomic
    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    cd543bf View commit details
    Browse the repository at this point in the history

  3. Fix clippy warnings 

    * clippy::needless_lifetimes
* clippy::unnecessary_mut_passed
* clippy::assign_op_pattern
* clippy::while_let_on_iterator
* clippy::let_and_return
* clippy::needless_range_loop
* clippy::len_zero
* clippy::single_match
* clippy::match_bool
* clippy::redundant_pattern_matching
* clippy::needless_return
* clippy::collapsible_if
* clippy::let_unit_value
* clippy::unit_arg
* clippy::duration_subsec
* clippy::redundant_closure
* clippy::new_without_default
* clippy::option_map_unit_fn
* clippy::cast_lossless
    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    0cdc174 View commit details
    Browse the repository at this point in the history

  4. cargo fmt --all

    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    c20c23d View commit details
    Browse the repository at this point in the history

  5. Remove default impls to private type added by 0cdc174

    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    063c4d2 View commit details
    Browse the repository at this point in the history

  6. Allow clippy::cast_ptr_alignment warnings

    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    9761168 View commit details
    Browse the repository at this point in the history

  7. Revert "Allow clippy::cast_ptr_alignment warnings" 

    This reverts commit 9761168.

False positive has been fixed in newer nightly.
    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    85addd5 View commit details
    Browse the repository at this point in the history

  8. Bump to newer nightly

    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    eb4d80a View commit details
    Browse the repository at this point in the history

  9. Use nightly-2019-07-17

    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    4191092 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into ci-clippy

    @taiki-e
    taiki-e committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    2b9ab4f View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. Move allow(clippy::trivially_copy_pass_by_ref) from crate to items

    @taiki-e
    taiki-e committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    f549d8b View commit details
    Browse the repository at this point in the history

  2. Move allow(clippy::mutex_atomic) from module to items

    @taiki-e
    taiki-e committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    cf79f7c View commit details
    Browse the repository at this point in the history

  3. timer: move contents of clock/clock.rs into clock/mod.rs

    @taiki-e
    taiki-e committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    f210250 View commit details
    Browse the repository at this point in the history

  4. sync: change the argument of WaiterNode::into_non_null to `self: Arc<… 

    …WaiterNode>`
    @taiki-e
    taiki-e committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    d63fc9c View commit details
    Browse the repository at this point in the history

  5. timer: change Entry::time_mut to unsafe fn

    @taiki-e
    taiki-e committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    b694a3b View commit details
    Browse the repository at this point in the history

  6. allow clippy::mut_from_ref and clippy::wrong_self_convention

    @taiki-e
    taiki-e committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    b5c8e69 View commit details
    Browse the repository at this point in the history

  7. threadpool: fix clippy::type_complexity

    @taiki-e
    taiki-e committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    56a7c33 View commit details
    Browse the repository at this point in the history

  8. remove unnecessary code

    @taiki-e
    taiki-e committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    edca75d View commit details
    Browse the repository at this point in the history

  9. add a comment

    @taiki-e
    taiki-e committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    2baee47 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. allow clippy::mutex_atomic at the project level

    @taiki-e
    taiki-e committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    ae3bd60 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ci-clippy

    @taiki-e
    taiki-e committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    3a9fa19 View commit details
    Browse the repository at this point in the history

  3. fix most of clippy::trivially_copy_pass_by_ref

    @taiki-e
    taiki-e committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    614aa54 View commit details
    Browse the repository at this point in the history

  4. fix more

    @taiki-e
    taiki-e committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    2a05364 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Merge branch 'master' into ci-clippy

    @taiki-e
    taiki-e authored Jul 25, 2019
    Configuration menu
    Copy the full SHA
    9c5cd86 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ci-clippy

    @taiki-e
    taiki-e committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    2035f15 View commit details
    Browse the repository at this point in the history