async-await: fix examples#1050
Merged
davidbarsky merged 1 commit intotokio-rs:masterfrom Apr 16, 2019
taiki-e:async-await-examples
Merged
async-await: fix examples#1050davidbarsky merged 1 commit intotokio-rs:masterfrom taiki-e:async-await-examples
davidbarsky merged 1 commit intotokio-rs:masterfrom
taiki-e:async-await-examples
Conversation
* Fix crate path in `Cargo.toml` of examples * Add `edition2018` to examples in the documentation to make it compiled on Rust 2018 * Fix an example in the documentation
Member
Author
|
This is blocked on #1049. |
Member
Author
|
To actually test the document, it needs to do one of the following in
Both ways have problems, so they are not included in the first commit. (Probably, replacing that only in the build for async / await, it can testing on CI.) |
davidbarsky
approved these changes
Apr 16, 2019
Member
davidbarsky
left a comment
There was a problem hiding this comment.
Thanks! merging this. I think @carllerche should be able to get a release out now that this and #1049 are in master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some examples in async-await fail to compile (even if updated to the new API by #1049).
Solution
Cargo.tomlof examplesedition2018to examples in the documentation to make it compiled on Rust 2018