Can we convert unix::SocketAddr to/from std::os::unix::net::SocketAddr? #6864
Labels
A-tokio
Area: The main tokio crate
C-feature-request
Category: A feature request.
M-net
Module: tokio/net
Comments
nmathewson
added
A-tokio
|
This is a historical deficiency due to mio also having a separate SocketAddr type too. However, mio v1 removed its SocketAddr type, so we don't really need to have our own type either. We probably can't get rid of our type, but adding conversions seems fine. |
nmathewson
added a commit
to nmathewson/tokio
that referenced
this issue
Sep 24, 2024
Implement `From` to convert `tokio::unix::SocketAddr` to and from Rust's `std::os::unix::net::SocketAddr`. These types were (I'm told) originally separate because `mio` had a distinct `SocketAddr` type. This patch makes it possible to convert between them more easily. Fixes: tokio-rs#6864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The arti project, for various reasons, needs to convert between
tokio::unix::SocketAddrandstd::os::unix::net::SocketAddr.The simplest approach here would be to implement
From<.>andInto<.>ontokio::unix::SocketAddr. We'd be happy to write a a patch to do that, but we're wondering if there is some reason not to do so?As it stands, we've had to make our own conversion function which is a bit ugly, and won't work in the future if Tokio adds support for "abstract" unix SocketAddrs.
Do you have any suggestions here? As noted, we'd be happy to write a patch if there's some approach that would be acceptable on Tokio's end.
The text was updated successfully, but these errors were encountered: