Doc comments are often written in the imperative mood #4074
Labels
A-tokio
Area: The main tokio crate
C-bug
Category: This is a bug.
E-easy
Call for participation: Experience needed to fix: Easy / not much
E-help-wanted
Call for participation: Help is requested to fix this issue.
T-docs
Topic: documentation
Version
1.8.1, 1.10.1
Description
tokio's doc comments are written in a mixture of the indicative mood and imperative mood. They should all be in the indicative mood (e.g. "Returns foo"), to match the stdlib and the standard rustdoc conventions.
For example,
tokio::runtime::Runtime
uses the imperative mood for all of its method comments, e.g.:tokio::runtime::Handle
uses a mixture of imperative and indicative moods:Note how
Handle::enter
is imperative, butHandle::current
is indicative (also note howHandle::current
is missing the trailing period).I mostly just look at
Runtime
andHandle
, so I'm not sure how prevalent this issue is across the rest of the API.The text was updated successfully, but these errors were encountered: