Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration should explicitly deregister the io on drop. #168

Closed
carllerche opened this issue Mar 2, 2018 · 0 comments
Closed

Registration should explicitly deregister the io on drop. #168

carllerche opened this issue Mar 2, 2018 · 0 comments
Milestone
v0.1.1 - Tokio Ru...

Comments

@carllerche
Copy link
Member

No description provided.

@carllerche carllerche added this to the v0.1.1 - Tokio Runtime milestone Mar 6, 2018
carllerche added a commit that referenced this issue Mar 6, 2018
@carllerche
Explicitly deregister I/O resources on drop
a99eebe 
Mio will be requiring `deregister` to be called explicitly in order to
guarantee that Poll releases any state associated with the I/O resource.
See tokio-rs/mio#753.

This patch adds an explicit `deregister` function to `Registration` and
updates `PollEvented` to call this function on drop.

`Registration::deregister` is also called on `PollEvented::into_inner`.

Closes #168
@carllerche carllerche mentioned this issue Mar 6, 2018
Merged
carllerche added a commit that referenced this issue Mar 6, 2018
@carllerche
Explicitly deregister I/O resources on drop (#189)
c769b91 
Mio will be requiring `deregister` to be called explicitly in order to
guarantee that Poll releases any state associated with the I/O resource.
See tokio-rs/mio#753.

This patch adds an explicit `deregister` function to `Registration` and
updates `PollEvented` to call this function on drop.

`Registration::deregister` is also called on `PollEvented::into_inner`.

Closes #168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.1 - Tokio Runtime
Development

No branches or pull requests
1 participant
@carllerche