build: Remove bundled protoc and build from source#610
Merged
LucioFranco merged 6 commits intomasterfrom Mar 28, 2022
Merged
Conversation
LucioFranco
commented
Mar 25, 2022
LucioFranco
commented
Mar 25, 2022
LucioFranco
commented
Mar 25, 2022
LucioFranco
commented
Mar 25, 2022
danburkert
added a commit
to sisudata/prost
that referenced
this pull request
Apr 7, 2022
)" This reverts commit fc9fbd9. The bundled protoc is very convenient, particularly for container builds.
danburkert
added a commit
to sisudata/prost
that referenced
this pull request
Apr 7, 2022
)" This reverts commit fc9fbd9. The bundled protoc is very convenient, particularly for container builds.
|
I just want to note that this change (I think) requires |
Member
Author
|
@Thomasdezeeuw right, cmake is now a requirement. There is #620 being worked on or you can just bundle the protoc binary yourself (or download it on CI) and provide it in the path to speed up compile times. |
mdrach
pushed a commit
to sisudata/prost
that referenced
this pull request
Aug 3, 2022
mdrach
pushed a commit
to sisudata/prost
that referenced
this pull request
Aug 3, 2022
)" This reverts commit fc9fbd9. The bundled protoc is very convenient, particularly for container builds.
mdrach
pushed a commit
to sisudata/prost
that referenced
this pull request
Aug 4, 2022
)" This reverts commit fc9fbd9. The bundled protoc is very convenient, particularly for container builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial attempt to remove bundled binaries from
prost-buildand to instead compile protobuf from source. This is a much safer approach and reduces prost's vulnerability to supply chain attacks.Reference #575 (comment) for more information on how this is implemented.
This also adds a
test-vendoredcrate which ensures that vendoring works.Closes #575