Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more I/O safety traits. #1831

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Implement more I/O safety traits. #1831

merged 2 commits into from
Sep 28, 2024

Conversation

sunfishcode
Copy link
Contributor

Implement From<OwnedFd> and Into<OwnedFd> for types that implement FromRawFd and IntoRawFd.

And on Windows, implement From<OwnedSocket>, Into<OwnedSocket>, and AsSocket for types that implement FromRawSocket, IntoRawSocket, and AsRawSocket.

@sunfishcode
Implement more I/O safety traits.
f8b5ae8 
Implement `From<OwnedFd>` and `Into<OwnedFd>` for types that implement
`FromRawFd` and `IntoRawFd`.

And on Windows, implement `From<OwnedSocket>`, `Into<OwnedSocket>`, and
`AsSocket` for types that implement `FromRawSocket`, `IntoRawSocket`,
and `AsRawSocket`.
@Thomasdezeeuw
Copy link
Collaborator

@sunfishcode can you fix this rustfmt CI failure: https://github.com/tokio-rs/mio/actions/runs/11077949124/job/30802514384?pr=1831 ? You can ignore the sanitizer failure.

@sunfishcode
Copy link
Contributor Author

@sunfishcode can you fix this rustfmt CI failure: https://github.com/tokio-rs/mio/actions/runs/11077949124/job/30802514384?pr=1831 ? You can ignore the sanitizer failure.

Done.

@Thomasdezeeuw Thomasdezeeuw merged commit d8d68ac into tokio-rs:master Sep 28, 2024
59 of 60 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @sunfishcode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunfishcode @Thomasdezeeuw