Work around 32 bits epoll_wait() bug (#1349) #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carllerche can you force commit this? I don't want to change more in the code to fix all Clippy lints. |
|
It seems like the trouble is with the min-rust test, not clippy? |
|
@Darksonn you're right the log crate seems to have updated there minimum rustc version. |
carllerche
approved these changes
Oct 23, 2020
|
@carllerche can you force merge this? The CI is failing because we 0.6.x still supports older Rust version, but we know the changes are good. |
A bug in kernels < 2.6.37 makes timeouts larger than LONG_MAX / CONFIG_HZ (approx. 30 minutes with CONFIG_HZ=1200) effectively infinite on 32 bits architectures. The magic number is the same constant used by libuv, see commit libuv/libuv@d1b5008e76.
Thomasdezeeuw
force-pushed
the
backport-1349
branch
from
bf10343 to
6d12629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in kernels < 2.6.37 makes timeouts larger than LONG_MAX /
CONFIG_HZ (approx. 30 minutes with CONFIG_HZ=1200) effectively
infinite on 32 bits architectures. The magic number is the same
constant used by libuv, see commit libuv/libuv@d1b5008e76.
Backport of #1349 to v0.6.