Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Frame::Integer should be signed 64-bit integer #128

Open
wuhaiji opened this issue May 30, 2023 · 2 comments
Open

The Frame::Integer should be signed 64-bit integer #128

wuhaiji opened this issue May 30, 2023 · 2 comments

Comments

@wuhaiji
Copy link

wuhaiji commented May 30, 2023

No description provided.

@wuhaiji wuhaiji changed the title the Frame::Integer should be signed Integer the Frame::Integer should be signed 64-bit integer May 30, 2023
@wuhaiji wuhaiji changed the title the Frame::Integer should be signed 64-bit integer The Frame::Integer should be signed 64-bit integer May 30, 2023
@nadmax
Copy link

nadmax commented Sep 3, 2023

Why?

@cjshearer
Copy link

https://redis.io/docs/reference/protocol-spec/#integers

This type is a CRLF-terminated string that represents a signed, base-10, 64-bit integer.

cjshearer added a commit to cjshearer/website that referenced this issue Mar 9, 2024
@cjshearer
fix: make redis integer frame signed
097a79d 
The documentation for the Frame enum in framing.md claims the Redis protocol frame for an integer is unsigned, which doesn't match the protocol spec: https://redis.io/docs/reference/protocol-spec/#integers

> This type is a CRLF-terminated string that represents a **signed**, base-10, 64-bit integer.

see also tokio-rs/mini-redis#128
@cjshearer cjshearer mentioned this issue Mar 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cjshearer @wuhaiji @nadmax