add as_mut to mutably access owned or mutably borrowed UnsafeCell safely
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datdenkikniet
commented
Mar 23, 2025
| /// | ||
| /// This is analogous to [`core::cell::UnsafeCell::get_mut`]. | ||
| #[track_caller] | ||
| pub fn as_mut(&mut self) -> MutRef<'_, T> { |
There was a problem hiding this comment.
I'm not entirely certain we even need tracking: if we can mutably borrow the value, we already have exclusive access to it, right? And because we borrow it mutably, no one can re-borrow it immutably until the borrow is dropped.
I've added the in-between struct so that someone can double-check my thoughts, but would be great to get some external input on it.
datdenkikniet
force-pushed
the
unsafe-cell-as-mut
branch
2 times, most recently
from
ff31094 to
f6fb23d
Compare
…rowed `UnsafeCell` safely.
datdenkikniet
force-pushed
the
unsafe-cell-as-mut
branch
from
f6fb23d to
e797da0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title.
This is the equivalent to
core::cell::UnsafeCell::get_mut, but with tracking. Instead of forcing unnecessaryunsafeon users, we can simply give them mutable access to an owned value.An example of where this causes unnecessary unsafe to be used can be found here.