fix(console): add dynamic constraints layout in task details screen #614

vrn21 · 2025-03-16T10:53:13Z

Changes I've made is for accommodating loong location names; ive changed the .. to the long name; it widens the task rectangle if its longer than the default (50%) and goes to the next line if its longer than what we can accommodate in a single line. This fixes issue #523 have attached screenshots of the same in the PR, before and after changes

These screenshots are what was the UI before my changes.

and these are the screenshots after my changes.

Changes i've made is for accomadating loong location names, ive changed the ... to the long name, it widens the task rectangle if its longer than the default 50% and goes to the next line if its longer than we can accomadate in a single line. This fixes issue tokio-rs#523 i have attached screenshots of the same in the PR, before and after changes

hds · 2025-03-17T14:02:37Z

@vrn21 Thanks for working on this topic! So far this PR looks good. However, with a fixed number of rows, when you go to 2 lines for the location text, the "Idle" time is getting dropped off, so that needs to be resolved too. I think that there are some hints in the original issue regarding how to approach that issue.

vrn21 · 2025-03-19T14:21:25Z

Thank you for looking into this @hds and Sorry for the delay,

but i'm still not sure how i'm supposed to move forward with this, i cant really determine what the height of the task_area is, before hand as in the current code, number of lines extra needed can be only computed after the each of the constraint is set. Could you help on this?

hds · 2025-03-19T15:17:55Z

In the code that exists, the areas are computed up front, based on the constraints provided. However, those areas aren't actually used until the Paragraph for each of the task overview and the waker stats are actually rendered at the bottom.

If the creation of the task and waker "widgets" (that's the variable name), is performed before the area is split on constraints, then we can already compute the number of lines that each one needs and use that as input to the Constraints::Length for the stats_area which is where they sit.

Does that help?

…ask details screen I've made the logic to look whether Location is longer than a single viewable length, even before setting constraints both vertically and horizontally. This fixes issue tokio-rs#523

vrn21 · 2025-03-21T14:43:58Z

Sorry again for the delay, Does this work @hds?

I've changed the logic to check whether locations is longer than what is viewable in a single line, before hand, assigning constraints (both vertical and horizontal) afterwards.

hds · 2025-03-22T09:53:53Z

This is looking good! There are a few style and layout things, but the functionality appears correct. I'll get you a proper review of this on Monday.

Thanks for your work!

hds

This is looking good, thanks! There are some changes I've suggested.

tokio-console/src/view/task.rs

vrn21 · 2025-03-24T12:40:35Z

@hds i've made the changes you've told to

hds

One point here where I think I wasn't clear regarding what I meant. And one other thing that I didn't notice before, sorry about that.

tokio-console/src/view/task.rs

please refer to earlier commits to see what changes have been made

vrn21 · 2025-03-24T17:31:52Z

@hds i've updated the latest changes requested

tokio-console/src/view/task.rs

long var names changed to shorter names Co-authored-by: Hayden Stainsby <[email protected]>

hds

What about this idea?

tokio-console/src/view/task.rs

vrn21 · 2025-03-27T19:01:18Z

Sorry for the delay again!

Yes, you're right, we could remove that unecessary if block. This doesnt really affect the view.

Attaching the current versions:

I'm commiting the changes( removing if block), i dont think this has any other problems with it.

vrn21 · 2025-03-30T09:22:53Z

@hds seems fine?

hds

Looks good. Thank you for all your work on this issue!

…onsole-v0.1.14 # console-api ## 0.9.0 - (2025-10-29) ### <a id = "0.9.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96)) This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))** This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) ### Fixed - Bump minimum version of tonic ([#593](#593)) ([1f41b61](1f41b61), closes [#592](#592), closes [#592](#592)) ### Updated - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # console-subscriber ## 0.5.0 - (2025-10-29) ### <a id = "0.5.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96)) This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))** This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Documented - Fix typo in doc comment ([3dbca7a](3dbca7a)) ### Updated - [**breaking**](#0.5.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # tokio-console ## 0.1.14 - (2025-10-29) ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Improve error msg when state streaming API is unimplemented ([#598](#598)) ([6ef148a](6ef148a)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Fixed - Add dynamic constraints layout in task details screen ([#614](#614)) ([ada7dab](ada7dab), fixes [#523](#523), fixes [#523](#523)) ### Updated - Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - Upgrade tonic to 0.14 ([#645](#645))

…onsole-v0.1.14 # console-api ## 0.9.0 - (2025-10-30) ### <a id = "0.9.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96)) This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))** This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) ### Fixed - Bump minimum version of tonic ([#593](#593)) ([1f41b61](1f41b61), closes [#592](#592), closes [#592](#592)) ### Updated - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # console-subscriber ## 0.5.0 - (2025-10-30) ### <a id = "0.5.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96)) This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))** This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Documented - Fix typo in doc comment ([3dbca7a](3dbca7a)) ### Updated - [**breaking**](#0.5.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # tokio-console ## 0.1.14 - (2025-10-30) ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Improve error msg when state streaming API is unimplemented ([#598](#598)) ([6ef148a](6ef148a)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Fixed - Add dynamic constraints layout in task details screen ([#614](#614)) ([ada7dab](ada7dab), fixes [#523](#523), fixes [#523](#523)) ### Updated - Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - Upgrade tonic to 0.14 ([#645](#645))

…onsole-v0.1.14 (#648) # console-api ## 0.9.0 - (2025-10-30) ### <a id = "0.9.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96)) This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))** This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) ### Fixed - Bump minimum version of tonic ([#593](#593)) ([1f41b61](1f41b61), closes [#592](#592), closes [#592](#592)) ### Updated - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # console-subscriber ## 0.5.0 - (2025-10-30) ### <a id = "0.5.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96)) This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))** This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Documented - Fix typo in doc comment ([3dbca7a](3dbca7a)) ### Updated - [**breaking**](#0.5.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # tokio-console ## 0.1.14 - (2025-10-30) ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Improve error msg when state streaming API is unimplemented ([#598](#598)) ([6ef148a](6ef148a)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Fixed - Add dynamic constraints layout in task details screen ([#614](#614)) ([ada7dab](ada7dab), fixes [#523](#523), fixes [#523](#523)) ### Updated - Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - Upgrade tonic to 0.14 ([#645](#645)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

vrn21 requested a review from a team as a code owner March 16, 2025 10:53

bug: idle line visible after dynamic alloc of layout constraints in t…

0f79e65

…ask details screen I've made the logic to look whether Location is longer than a single viewable length, even before setting constraints both vertically and horizontally. This fixes issue tokio-rs#523

hds requested changes Mar 24, 2025

View reviewed changes

vrn21 force-pushed the main branch from 4b4609d to b04ad50 Compare March 24, 2025 12:47

hds requested changes Mar 24, 2025

View reviewed changes

tokio-console/src/view/task.rs Show resolved Hide resolved

tokio-console/src/view/task.rs Outdated Show resolved Hide resolved

tokio-console/src/view/task.rs Outdated Show resolved Hide resolved

tokio-console/src/view/task.rs Outdated Show resolved Hide resolved

bug: dynamic alloc of layout constraints, requested changes changed

2e5a512

please refer to earlier commits to see what changes have been made

vrn21 force-pushed the main branch from b04ad50 to 2e5a512 Compare March 24, 2025 17:31

vrn21 requested a review from hds March 25, 2025 06:46

hds reviewed Mar 25, 2025

View reviewed changes

tokio-console/src/view/task.rs Outdated Show resolved Hide resolved

tokio-console/src/view/task.rs Outdated Show resolved Hide resolved

bug fix: dynamic alloc of layout constraints in task details screen,

93319d5

long var names changed to shorter names Co-authored-by: Hayden Stainsby <[email protected]>

hds reviewed Mar 25, 2025

View reviewed changes

tokio-console/src/view/task.rs Outdated Show resolved Hide resolved

buf: refactored if block in task constraints

3ed6387

hds approved these changes Mar 31, 2025

View reviewed changes

hds changed the title ~~bug: dynamic alloc of layout constraints in task details screen~~ fix: add dynamic constraints layout in task details screen Mar 31, 2025

hds changed the title ~~fix: add dynamic constraints layout in task details screen~~ fix(console): add dynamic constraints layout in task details screen Mar 31, 2025

hds merged commit ada7dab into tokio-rs:main Mar 31, 2025
19 checks passed

github-actions bot mentioned this pull request Jan 22, 2025

chore: release #595

Closed

github-actions bot mentioned this pull request Apr 12, 2025

chore: release ShabbirHasan1/console#1

Open

hds mentioned this pull request Apr 14, 2025

feat: Adjust task and waker panel for long names #527

Closed

github-actions bot mentioned this pull request Oct 30, 2025

chore: release console-api-v0.9.0, console-subscriber-v0.5.0, tokio-console-v0.1.14 #648

Merged

Uh oh!

fix(console): add dynamic constraints layout in task details screen #614

fix(console): add dynamic constraints layout in task details screen #614

Uh oh!

Conversation

vrn21 commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hds commented Mar 17, 2025

Uh oh!

vrn21 commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hds commented Mar 19, 2025

Uh oh!

vrn21 commented Mar 21, 2025

Uh oh!

hds commented Mar 22, 2025

Uh oh!

hds left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vrn21 commented Mar 24, 2025

Uh oh!

hds left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vrn21 commented Mar 24, 2025

Uh oh!

Uh oh!

Uh oh!

hds left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vrn21 commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vrn21 commented Mar 30, 2025

Uh oh!

hds left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vrn21 commented Mar 16, 2025 •

edited

Loading

vrn21 commented Mar 19, 2025 •

edited

Loading

vrn21 commented Mar 27, 2025 •

edited

Loading