Skip to content

feat: improve error msg when state streaming API is unimplemented #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: improve error msg when state streaming API is unimplemented #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tokio-console/src/conn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,18 @@ impl Connection {
let update_stream =
Box::new(client.watch_updates(update_request).await?.into_inner());
let state_request = tonic::Request::new(StateRequest {});
let state_stream = Box::new(client.watch_state(state_request).await?.into_inner());
let state_stream = match client.watch_state(state_request).await {
Ok(stream) => Box::new(stream.into_inner()),
Err(e) => {
if e.code() == tonic::Code::Unimplemented {
tracing::error!(
"The server at {} does not support state streaming. Please update the console-subscriber to v0.5.0 or later version.",
self.target
);
}
return Err(e.into());
}
};
Ok::<State, Box<dyn Error + Send + Sync>>(State::Connected {
client,
update_stream,
Expand Down
Loading