Skip to content

Conversation

@0xPoe
Copy link
Collaborator

@0xPoe 0xPoe commented Aug 19, 2024

I know the best solution is to ensure we can distinguish singular or plural here. But for now, let's correct the grammar issue first.

I know the best solution is to ensure we can distinguish singular or plural here.
But for now, let's correct the grammar issue first.
@0xPoe 0xPoe requested a review from a team as a code owner August 19, 2024 15:35
@0xPoe 0xPoe requested a review from hds August 19, 2024 15:36
Copy link
Collaborator

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@0xPoe 0xPoe merged commit f8e1bee into tokio-rs:main Aug 29, 2024
@0xPoe 0xPoe deleted the rustin-patch-lost-waker branch August 29, 2024 13:36
@0xPoe
Copy link
Collaborator Author

0xPoe commented Aug 29, 2024

Thanks for your review! 💚 💙 💜 💛 ❤️

hds pushed a commit that referenced this pull request Oct 24, 2024
…onsole-v0.1.13

## 🤖 New release
* `tokio-console`: 0.1.12 -> 0.1.13 (✓ API compatible changes)
* `console-api`: 0.8.0 -> 0.8.1 (✓ API compatible changes)
* `console-subscriber`: 0.4.0 -> 0.4.1 (✓ API compatible changes)

## Changelog

## `tokio-console`

## 0.1.13 - (2024-10-24)

### Added

- Add large future lints ([#587](#587)) ([ae17230](ae17230))

### Fixed

- Correct the grammar issue ([#579](#579)) ([f8e1bee](f8e1bee))

## `console-api`

## 0.8.1 - (2024-10-24)

_No outward facing changes_

## `console-subscriber`

## 0.4.1 - (2024-10-24)

### Added

- Add large future lints ([#587](#587)) ([ae17230](ae17230))
hds pushed a commit that referenced this pull request Oct 24, 2024
…onsole-v0.1.13 (#581)

## 🤖 New release
* `tokio-console`: 0.1.12 -> 0.1.13 (✓ API compatible changes)
* `console-api`: 0.8.0 -> 0.8.1 (✓ API compatible changes)
* `console-subscriber`: 0.4.0 -> 0.4.1 (✓ API compatible changes)

## Changelog

## `tokio-console`

## 0.1.13 - (2024-10-24)

### Added

- Add large future lints ([#587](#587)) ([ae17230](ae17230))

### Fixed

- Correct the grammar issue ([#579](#579)) ([f8e1bee](f8e1bee))

## `console-api`

## 0.8.1 - (2024-10-24)

_No outward facing changes_

## `console-subscriber`

## 0.4.1 - (2024-10-24)

### Added

- Add large future lints ([#587](#587)) ([ae17230](ae17230))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants