Properly respond with sec-websocket-protocol under http/2 #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, looks good! Can you modify the |
yanns
reviewed
Jan 6, 2025
axum/src/extract/ws.rs
Outdated
| mut socket: WebSocketStream<S>, | ||
| headers: &http::HeaderMap, | ||
| ) { | ||
| dbg!(headers); |
There was a problem hiding this comment.
The CI is complaining about this line. dbg! should only be used locally when debugging some issues.
Can you remove this line?
Suggested change
| dbg!(headers); |
coolreader18
force-pushed
the
http2-websocket-subprotocol
branch
from
9a4f267 to
95f2535
Compare
finnbear
added a commit
to finnbear/axum-tws
that referenced
this pull request
Jan 15, 2025
finnbear
added a commit
to finnbear/axum-tws
that referenced
this pull request
Jan 15, 2025
robertwayne
pushed a commit
to robertwayne/axum-tws
that referenced
this pull request
Jan 16, 2025
* Port HTTP/2 support. * Port tokio-rs/axum#3141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Was looking at the
wscode and noticed that the subprotocol never gets properly communicated to the client if the connection is HTTP/2.Solution
Add the
sec-websocket-protocolheader irrespective of HTTP version. A response with that header is still a valid HTTP/2 websocket handshake, as per RFC8441.