don't set MSRV and only run doctests on nightly #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
force-pushed
the
abandon-msrv
branch
2 times, most recently
from
7960ce2
to
31005fa
Compare
We have too many dependencies to actually guarantee our MSRV. We only run doctests on nightly so we don't have to generalize doctests for slightly different line numbers across different Rust versions. Our integration tests do generalize in this way, so we still run those on both stable and nightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have too many dependencies to actually guarantee our MSRV.
We only run doctests on nightly so we don't have to generalize doctests for slightly different line numbers across different Rust versions. Our integration tests do generalize in this way, so we still run those on both stable and nightly.