Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0]: Delete token group: Treat as destructive confirm #2647

Closed
six7 opened this issue Apr 14, 2024 · 0 comments · Fixed by #2685
Closed

[2.0]: Delete token group: Treat as destructive confirm #2647

six7 opened this issue Apr 14, 2024 · 0 comments · Fixed by #2685
Assignees
@six7
Labels
plugin v2 variables, UI, WTCG format, Bitbucket token group UI affordance UI Destructive

Comments

@six7
Copy link
Collaborator

six7 commented Apr 14, 2024

We don't have a destructive looking action and now we've placed the buttons so close together that we've made it even easier to complete this destructive task.
there's no undo for this action
Currently the buttons are separated on destructive tasks but beta build doesn't do this
If we don't want to introduce a proper destructive UX flow or UI element we should
ensure the buttons are far apart to avoid a mistake
adjust the copy to tell the user they can't go back or undo so they understand the

Image

Let's make it so the confirm() can get a variant: destructive, which would render the confirmation button in variant: danger
@six7 six7 added the plugin v2 variables, UI, WTCG format, Bitbucket label Apr 14, 2024
@six7 six7 moved this to 📤 Ready for dev in Tokens Studio for Figma Roadmap Apr 14, 2024
@six7 six7 self-assigned this Apr 26, 2024
@six7 six7 moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Apr 26, 2024
@six7 six7 mentioned this issue Apr 26, 2024
Merged
six7 added a commit that referenced this issue Apr 26, 2024
@six7
2.0: Polish UI bugs (#2685)
cf16c39 
### Why does this PR exist?

Fixes a bunch of UI polish issues

Fixes #2646
Fixes #2584
Fixes #2647
Fixes #2650
Fixes #2682

### What does this pull request do?

Decided to introduce a variant: danger to our `useConfirm`
Decided to show disabled options in a disabled state when right clicking
token set groups
Fixed a bunch of the visual issues like Portal and spacing of a few
items

| Feature                | Before | After |
|------------------------|--------|-------|
| Inspect view |
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/6fde8e2f-4884-49b7-8166-7a5ea7090cab)
|
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/e16a1880-b37c-4fd2-b164-4295b27ec619)
|
| Right click token set group |
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/792485a5-1805-4359-9e3a-931520167015)
|
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/2de41f26-1cac-4e26-a4bb-1e5fa232c45f)
|
| Duplicate token group |
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/c4c66df6-c59e-44c4-8939-bb8c514b0cd4)
|
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/a9998551-db28-4206-b778-44e273e01a13)
|
| Delete token group |
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/d855d5ce-610f-45aa-8b79-ef7deb1bdec4)
|
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/d634a900-673a-47e3-9357-fe76161ea7b3)
|
| Downshift Input |
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/240887ca-d6ae-4b3a-a6c1-a627d45d2877)
|
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/5918ac9c-65f9-4cd1-893a-ae5cc21945cf)
|
| Mentions Input |
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/300ba5e0-fcb4-4524-aa74-8970d8977d7e)
|
![](https://github.com/tokens-studio/figma-plugin/assets/4548309/e8779162-ca3f-44f5-98dc-ac85388d503c)
|
@six7 six7 closed this as completed Apr 26, 2024
@github-project-automation github-project-automation bot moved this from 🕜 In Progress to ✅ Done in Tokens Studio for Figma Roadmap Apr 26, 2024
@six7 six7 mentioned this issue Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@six7 six7

Labels
plugin v2 variables, UI, WTCG format, Bitbucket token group UI affordance UI Destructive
Projects
Tokens Studio for Figma Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2.0: Polish UI bugs tokens-studio/figma-plugin
2 participants
@six7 @SamIam4Hyma