Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

size/numeric Alias suggestions stopped working in Typography tokens #2528

Closed
leemlller opened this issue Mar 4, 2024 · 1 comment · Fixed by #2565
Closed

size/numeric Alias suggestions stopped working in Typography tokens #2528

leemlller opened this issue Mar 4, 2024 · 1 comment · Fixed by #2565
Assignees
Labels
bug Something isn't working token type typography composite token type token value references alias

Comments

@leemlller
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Create any numeric token in Sizing or Dimension ex. sizing/100 with value 16
  2. not fully input this alias in Typography fontSize, LineHeight, ParagraphSpacing etc... {sizing.1...
  3. See error in suggestion dropdown "Not found"

Expected behavior
If you input full path {sizing.100} you'll see correctly calculated preview of 16 and after save it will work as indented

Screenshots or Screencasts
(https://tokens-studio.slack.com/archives/C02DLQXNY6Q/p1709571132215559)](https://tokens-studio.slack.com/archives/C02DLQXNY6Q/p1709571132215559)

Figma file (optional)
Send us the link to a Figma file containing a reproducible example

JSON (optional)

{
  "global": {
    "s": {
      "100": {
        "value": "16",
        "type": "sizing"
      }
    },
    "t": {
      "s100": {
        "value": {
          "fontSize": "{s.100}"
        },
        "type": "typography"
      },
      "d100": {
        "value": {
          "fontSize": "{d.100}"
        },
        "type": "typography"
      }
    },
    "d": {
      "100": {
        "value": "16px",
        "type": "dimension"
      }
    }
  }
}
@rbosker rbosker added the bug Something isn't working label Mar 5, 2024
@rbosker rbosker moved this from 📥 Triage to 📤 Ready for dev in Tokens Studio for Figma Roadmap Mar 11, 2024
@six7 six7 self-assigned this Mar 29, 2024
@six7 six7 moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Mar 29, 2024
six7 added a commit that referenced this issue Mar 30, 2024
@six7 six7 moved this from 🕜 In Progress to 👀 Needs review in Tokens Studio for Figma Roadmap Mar 30, 2024
six7 added a commit that referenced this issue Apr 2, 2024
…#2565)

### Why does this PR exist?

Closes #2528

### What does this pull request do?

Adds number and dimension token types to a couple of typography
suggested types
@six7
Copy link
Collaborator

six7 commented Apr 2, 2024

Will be fixed in 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working token type typography composite token type token value references alias
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants