feat(api): files.upload supported with custom file checks #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blainekasten
force-pushed
the
blaine/eng-48225-update-file-upload-setup-to-not-be-controlled-by-stainless
branch
from
b8da47e to
2b16260
Compare
blainekasten
commented
Nov 17, 2025
| process.stdout.cursorTo(0); | ||
| process.stdout.write(progressBar, () => {}); | ||
| await sleep(2000); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I believe this was a bad port. The displayProgress from the Python library is primarily for their CLI. The SDK itself should not be outputing to stdout.
blainekasten
force-pushed
the
blaine/eng-48225-update-file-upload-setup-to-not-be-controlled-by-stainless
branch
4 times, most recently
from
fdf80b2 to
2f85fbb
Compare
blainekasten
force-pushed
the
blaine/eng-48225-update-file-upload-setup-to-not-be-controlled-by-stainless
branch
from
273f4fe to
8774e72
Compare
Nutlope
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we can release #199 - we need to move the file upload logic into the files upload code. Since we've removed the file uploads from the typescript and python generated code, we are now able to handle this ourselves.
I used cursor to convert the current implementation of the file checks into typescript and include in this PR. I additionally copied their tests and moved them here as well.