-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: keck apis #233
refactor: keck apis #233
Conversation
Maybe we can consider encapsulating some transaction apis into with_trx like this: workspace.with_trx(|trx| {
trx.get(&block_id);
}); And all the block instances obtained in trx are an instance that encapsulates the original block instance and transaction. At this point, we can continue to use this instance to operate the block: workspace.with_trx(|trx| {
let block = trx.get(&block_id);
block.set("key", "value");
}); |
Agree, |
3c62bfd
to
285af79
Compare
I added more improvement intents in #235 |
No description provided.