Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): warning when open center peek #8819

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Nov 14, 2024

No description provided.

Copy link

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review November 14, 2024 06:35
Copy link
Member Author

EYHN commented Nov 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c712e87. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.27%. Comparing base (343152e) to head (c712e87).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ages/common/infra/src/modules/doc/services/docs.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8819      +/-   ##
==========================================
- Coverage   70.27%   70.27%   -0.01%     
==========================================
  Files         549      549              
  Lines       33926    33930       +4     
  Branches     3051     3051              
==========================================
+ Hits        23843    23844       +1     
- Misses       9711     9714       +3     
  Partials      372      372              
Flag Coverage Δ
server-test 77.18% <ø> (ø)
unittest 46.08% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/fix/warning-on-open-peek branch from 03ca7ee to dcb7ba6 Compare November 14, 2024 08:07
@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Nov 14, 2024
Copy link

graphite-app bot commented Nov 14, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/fix/warning-on-open-peek branch from dcb7ba6 to c712e87 Compare November 14, 2024 09:04
@graphite-app graphite-app bot merged commit c712e87 into canary Nov 14, 2024
46 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/warning-on-open-peek branch November 14, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants