Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): revise open app card text #8783

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 11, 2024

fix AF-1669

Copy link

graphite-app bot commented Nov 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Nov 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cc9a23e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (6fe2e42) to head (cc9a23e).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8783   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files         549      549           
  Lines       33891    33891           
  Branches     3042     3042           
=======================================
  Hits        23814    23814           
  Misses       9707     9707           
  Partials      370      370           
Flag Coverage Δ
server-test 77.18% <ø> (ø)
unittest 45.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Nov 12, 2024

Merge activity

  • Nov 11, 9:07 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 11, 9:23 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server E2E Test 1/3').
  • Nov 11, 9:37 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 11, 10:31 PM EST: A user merged this pull request with the Graphite merge queue.

@pengx17 pengx17 force-pushed the 11-11-fix_core_revise_open_app_card_text branch from cb298ce to cc9a23e Compare November 12, 2024 03:16
@graphite-app graphite-app bot merged commit cc9a23e into canary Nov 12, 2024
46 checks passed
@graphite-app graphite-app bot deleted the 11-11-fix_core_revise_open_app_card_text branch November 12, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants