Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): typo of identifier when override config #8773

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Nov 11, 2024

Fixed a typo in the mobile patches where the wrong identifier was being used to override affine:page configs.

Copy link

graphite-app bot commented Nov 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Nov 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 81fc9e1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.20%. Comparing base (35f3fc7) to head (81fc9e1).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8773      +/-   ##
==========================================
- Coverage   70.28%   70.20%   -0.08%     
==========================================
  Files         549      549              
  Lines       33891    33891              
  Branches     3042     3042              
==========================================
- Hits        23819    23794      -25     
- Misses       9701     9727      +26     
+ Partials      371      370       -1     
Flag Coverage Δ
server-test 77.12% <ø> (-0.07%) ⬇️
unittest 45.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Nov 12, 2024

Merge activity

Fixed a typo in the mobile patches where the wrong identifier was being used to override `affine:page` configs.
@L-Sun L-Sun force-pushed the l-sun/fix/identifier-typo-of-override branch from c2fd8a4 to 81fc9e1 Compare November 12, 2024 02:24
@graphite-app graphite-app bot merged commit 81fc9e1 into canary Nov 12, 2024
46 checks passed
@graphite-app graphite-app bot deleted the l-sun/fix/identifier-typo-of-override branch November 12, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants