Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra): remove useless flags #8748

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Nov 8, 2024

fix AF-1611

@graphite-app graphite-app bot requested review from CatsJuice, JimmFly, EYHN and pengx17 and removed request for JimmFly November 8, 2024 09:52
Copy link

graphite-app bot commented Nov 8, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Nov 8, 2024
Copy link
Member Author

forehalo commented Nov 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 02dbe13. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.20%. Comparing base (73d0e64) to head (02dbe13).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8748   +/-   ##
=======================================
  Coverage   70.20%   70.20%           
=======================================
  Files         546      546           
  Lines       33753    33753           
  Branches     3026     3026           
=======================================
+ Hits        23695    23697    +2     
+ Misses       9697     9695    -2     
  Partials      361      361           
Flag Coverage Δ
server-test 77.18% <ø> (ø)
unittest 45.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Nov 8, 2024

Merge activity

@graphite-app graphite-app bot merged commit 02dbe13 into canary Nov 8, 2024
46 checks passed
@graphite-app graphite-app bot deleted the 61/remove-useless-flags branch November 8, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants