Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add open in app hint text #8728

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 7, 2024

fix AF-1625

Copy link

graphite-app bot commented Nov 7, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Nov 7, 2024
Copy link
Collaborator Author

pengx17 commented Nov 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 727130e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pengx17 pengx17 force-pushed the xp/11-07-fix_core_add_open_in_app_hint_text branch from cbf7fdd to 88c768a Compare November 7, 2024 03:42
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.11%. Comparing base (c79b93b) to head (727130e).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8728   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files         546      546           
  Lines       33797    33797           
  Branches     3043     3043           
=======================================
  Hits        23697    23697           
  Misses       9739     9739           
  Partials      361      361           
Flag Coverage Δ
server-test 77.18% <ø> (ø)
unittest 44.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Nov 7, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/11-07-fix_core_add_open_in_app_hint_text branch from d83164d to 727130e Compare November 7, 2024 04:10
@graphite-app graphite-app bot merged commit 727130e into canary Nov 7, 2024
46 checks passed
@graphite-app graphite-app bot deleted the xp/11-07-fix_core_add_open_in_app_hint_text branch November 7, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants