Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): set edgeless theme on doc created #8670

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Nov 1, 2024

No description provided.

Copy link

graphite-app bot commented Nov 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review November 1, 2024 18:06
@github-actions github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app app:core labels Nov 1, 2024
Copy link
Member Author

EYHN commented Nov 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 12e3cf1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.67%. Comparing base (a4f27ef) to head (12e3cf1).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ages/common/infra/src/modules/doc/services/docs.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8670   +/-   ##
=======================================
  Coverage   70.66%   70.67%           
=======================================
  Files         545      543    -2     
  Lines       33772    33770    -2     
  Branches     3072     3072           
=======================================
+ Hits        23866    23867    +1     
+ Misses       9545     9542    -3     
  Partials      361      361           
Flag Coverage Δ
server-test 77.72% <ø> (ø)
unittest 45.17% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/refactor/set-edgeless-theme-doc-created branch from d146800 to f82b21a Compare November 4, 2024 04:23
Copy link

graphite-app bot commented Nov 4, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/refactor/set-edgeless-theme-doc-created branch from f82b21a to 12e3cf1 Compare November 4, 2024 04:38
@graphite-app graphite-app bot merged commit 12e3cf1 into canary Nov 4, 2024
45 of 46 checks passed
@graphite-app graphite-app bot deleted the eyhn/refactor/set-edgeless-theme-doc-created branch November 4, 2024 04:52
donteatfriedrice added a commit that referenced this pull request Nov 5, 2024
## Feat

- feat: add pdf viewer to playground (#8650)
- feat: add view toggle menu to toolbar of attachment block (#8660)
- feat: attachment embedded view supports configurable (#8658)

## Fix

- fix: tidy up after multiple images uploaded (#8671)
- fix: unable to add caption for linked document of embedded view (#8670)
- fix(blocks): code block should update highlight when theme changed (#8669)
- fix(edgeless): allow right click of tool controller (#8652)
- fix(database): short name of tag type (#8665)
- fix: the content of formula should contain spaces (#8647)
- fix: import notion database with title (#8661)
- fix(page): bookmark block selected style (#8656)
- fix(edgeless): switching shape style and color, the preview does not change in time (#8655)
- fix(blocks): size of icons are not consistent in keyboard toolbar (#8653)
- fix: use host instead of offsetParent (#8651)

## Refactor

- refactor(database): filter ui (#8611)

## Ci

- ci: renovate pr title lint (#8666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants