Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow peek view to be closed by the caller && bump bs #8542

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Oct 18, 2024

depends on toeverything/blocksuite#8558
fix BS-1570

Copy link

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Oct 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Oct 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 001eacc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (3f7752e) to head (81029db).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8542   +/-   ##
=======================================
  Coverage   70.17%   70.17%           
=======================================
  Files         536      536           
  Lines       33700    33700           
  Branches     3023     3023           
=======================================
  Hits        23648    23648           
  Misses       9697     9697           
  Partials      355      355           
Flag Coverage Δ
server-test 77.08% <ø> (ø)
unittest 45.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 marked this pull request as ready for review October 18, 2024 06:22
@pengx17 pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 86dfa0e to d1c295d Compare October 21, 2024 09:31
@fundon fundon force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from d1c295d to f8f786b Compare October 22, 2024 09:05
@fundon fundon mentioned this pull request Oct 22, 2024
2 tasks
@pengx17 pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from f8f786b to 03cb2c8 Compare October 22, 2024 10:30
@github-actions github-actions bot added the mod:i18n Related to i18n label Oct 22, 2024
@fundon fundon force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 03cb2c8 to a459499 Compare October 22, 2024 23:55
@pengx17 pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from a459499 to 879aac4 Compare October 25, 2024 04:43
@doouding doouding force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 879aac4 to b4af76f Compare October 25, 2024 06:46
@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:env mod:component app:electron Related to electron app mod:dev labels Oct 25, 2024
@pengx17 pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 94ae12e to 52c2740 Compare October 28, 2024 05:07
@fundon fundon force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 52c2740 to 34844fe Compare October 28, 2024 06:33
@fundon fundon mentioned this pull request Oct 28, 2024
7 tasks
@doouding doouding force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 34844fe to 001eacc Compare October 28, 2024 08:18
Copy link

graphite-app bot commented Oct 28, 2024

Merge activity

@EYHN EYHN force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 001eacc to 81029db Compare October 28, 2024 09:16
@graphite-app graphite-app bot merged commit 81029db into canary Oct 28, 2024
39 checks passed
@graphite-app graphite-app bot deleted the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch October 28, 2024 09:32
This was referenced Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component mod:dev mod:env mod:i18n Related to i18n mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants