Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): cleanup i18n file #8318

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Sep 19, 2024

No description provided.

Copy link

graphite-app bot commented Sep 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Sep 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the mod:i18n Related to i18n label Sep 19, 2024
Copy link

nx-cloud bot commented Sep 19, 2024

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.70%. Comparing base (bed70cd) to head (096f50b).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/frontend/i18n/src/index.ts 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8318      +/-   ##
==========================================
+ Coverage   72.67%   72.70%   +0.02%     
==========================================
  Files         519      519              
  Lines       32838    32853      +15     
  Branches     2851     2854       +3     
==========================================
+ Hits        23865    23885      +20     
+ Misses       8942     8937       -5     
  Partials       31       31              
Flag Coverage Δ
server-test 78.87% <ø> (+0.06%) ⬆️
unittest 49.71% <13.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/chore/cleanup-i18n branch 2 times, most recently from e594dd2 to 6e72993 Compare September 19, 2024 14:51
@EYHN EYHN marked this pull request as ready for review September 19, 2024 14:51
@EYHN EYHN force-pushed the eyhn/chore/cleanup-i18n branch 3 times, most recently from 4b799eb to 65f708d Compare September 19, 2024 16:11
@github-actions github-actions bot added the test Related to test cases label Sep 19, 2024
@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Sep 19, 2024
Copy link

graphite-app bot commented Sep 20, 2024

Merge activity

@graphite-app graphite-app bot merged commit 096f50b into canary Sep 20, 2024
38 checks passed
@graphite-app graphite-app bot deleted the eyhn/chore/cleanup-i18n branch September 20, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants