Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): reduce unnecessary layers #8292

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Sep 18, 2024

CleanShot 2024-09-18 at 16.41.23@2x.png

Copy link

graphite-app bot commented Sep 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 18, 2024

@CatsJuice CatsJuice marked this pull request as ready for review September 18, 2024 08:42
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused by willChange?

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.71%. Comparing base (bba9e79) to head (ce2ce26).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8292   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files         519      519           
  Lines       32797    32797           
  Branches     2973     2973           
=======================================
  Hits        23847    23847           
  Misses       8919     8919           
  Partials       31       31           
Flag Coverage Δ
server-test 78.86% <ø> (ø)
unittest 49.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Sep 19, 2024

Merge activity

@graphite-app graphite-app bot merged commit ce2ce26 into canary Sep 19, 2024
38 checks passed
@graphite-app graphite-app bot deleted the catsjuice/chore/reduce-layer branch September 19, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants