Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default style of new document does not follow AFFiNE settings #8291

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

akumatus
Copy link
Member

@akumatus akumatus commented Sep 18, 2024

Close issue BS-1377.

What changed?

  • Add initDocFromProps function to initialize the document with specific props.
  • Extract docProps from editor settings and pass it to docsService.createDoc function.
🎥 Video uploaded on Graphite:

Copy link

graphite-app bot commented Sep 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels Sep 18, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @akumatus and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 18, 2024

@akumatus akumatus marked this pull request as ready for review September 18, 2024 08:16
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.71%. Comparing base (fab23d2) to head (d00b125).
Report is 3 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/infra/src/initialization/index.ts 0.00% 9 Missing ⚠️
...ages/common/infra/src/modules/doc/services/docs.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8291      +/-   ##
==========================================
+ Coverage   72.66%   72.71%   +0.05%     
==========================================
  Files         519      519              
  Lines       32774    32776       +2     
  Branches     2961     2964       +3     
==========================================
+ Hits        23814    23832      +18     
+ Misses       8929     8913      -16     
  Partials       31       31              
Flag Coverage Δ
server-test 78.86% <ø> (+0.06%) ⬆️
unittest 49.65% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Sep 18, 2024

Merge activity

…8291)

Close issue [BS-1377](https://linear.app/affine-design/issue/BS-1377).

### What changed?
- Add `initDocFromProps` function to initialize the document with specific props.
- Extract `docProps` from editor settings and pass it to `docsService.createDoc` function.

<div class='graphite__hidden'>
          <div>🎥 Video uploaded on Graphite:</div>
            <a href="https://app.graphite.dev/media/video/sJGviKxfE3Ap685cl5bj/8082a8bd-ab3d-432c-9d3e-2f1d1a8398eb.mov">
              <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/sJGviKxfE3Ap685cl5bj/8082a8bd-ab3d-432c-9d3e-2f1d1a8398eb.mov">
            </a>
          </div>
<video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/sJGviKxfE3Ap685cl5bj/8082a8bd-ab3d-432c-9d3e-2f1d1a8398eb.mov">录屏2024-09-18 16.13.43.mov</video>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants