Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate environment to BUILD_CONFIG #8206

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

forehalo
Copy link
Member

No description provided.

Copy link
Member Author

forehalo commented Sep 11, 2024

Copy link

graphite-app bot commented Sep 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:env mod:component app:electron Related to electron app app:core labels Sep 11, 2024
Copy link

nx-cloud bot commented Sep 11, 2024

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 14.77273% with 75 lines in your changes missing coverage. Please review.

Project coverage is 53.50%. Comparing base (561f96b) to head (a387e4a).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...frontend/core/src/components/app-sidebar/index.tsx 8.33% 11 Missing ⚠️
...nd/core/src/components/affine/auth/use-captcha.tsx 0.00% 5 Missing ⚠️
...es/frontend/core/src/hooks/affine/use-shortcuts.ts 20.00% 4 Missing ⚠️
...ges/frontend/core/src/commands/affine-settings.tsx 0.00% 3 Missing ⚠️
...setting-modal/general-setting/appearance/index.tsx 0.00% 3 Missing ⚠️
...src/modules/navigation/view/navigation-buttons.tsx 25.00% 3 Missing ⚠️
packages/common/infra/src/atom/settings.ts 0.00% 1 Missing and 1 partial ⚠️
...src/components/auth-components/onboarding-page.tsx 0.00% 2 Missing ⚠️
...ges/frontend/core/src/commands/affine-creation.tsx 0.00% 2 Missing ⚠️
...frontend/core/src/components/affine/auth/oauth.tsx 0.00% 2 Missing ⚠️
... and 31 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8206      +/-   ##
==========================================
+ Coverage   53.49%   53.50%   +0.01%     
==========================================
  Files        1264     1264              
  Lines       49488    49474      -14     
  Branches     6010     6007       -3     
==========================================
- Hits        26472    26471       -1     
+ Misses      22974    22961      -13     
  Partials       42       42              
Flag Coverage Δ
server-test 78.85% <ø> (ø)
unittest 25.86% <14.77%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN changed the base branch from 61/build-config to graphite-base/8206 September 13, 2024 07:28
@EYHN EYHN changed the base branch from graphite-base/8206 to canary September 13, 2024 07:40
Copy link

graphite-app bot commented Sep 13, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component mod:dev mod:env mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants