Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): should be bound to the correct object #8121

Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Sep 5, 2024

Screenshot 2024-09-05 at 18 05 35

Copy link

graphite-app bot commented Sep 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Sep 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 5, 2024

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (d3f50a2) to head (017e89f).
Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
...rontend/core/src/modules/editor/entities/editor.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8121      +/-   ##
==========================================
+ Coverage   52.39%   52.43%   +0.04%     
==========================================
  Files        1230     1230              
  Lines       48359    48361       +2     
  Branches     5907     5907              
==========================================
+ Hits        25339    25360      +21     
+ Misses      22645    22621      -24     
- Partials      375      380       +5     
Flag Coverage Δ
server-test 77.31% <ø> (+0.03%) ⬆️
unittest 25.25% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon changed the base branch from fundon/09_05_should_open_new_tab_with_parameters to graphite-base/8121 September 5, 2024 10:30
@fundon fundon force-pushed the fundon/09_05_should_be_bound_to_the_correct_object branch from cc08cc1 to 8358191 Compare September 5, 2024 10:43
@fundon fundon changed the base branch from graphite-base/8121 to canary September 5, 2024 10:44
@fundon fundon force-pushed the fundon/09_05_should_be_bound_to_the_correct_object branch from 8358191 to 491a058 Compare September 5, 2024 10:44
Copy link

graphite-app bot commented Sep 5, 2024

Merge activity

@EYHN EYHN force-pushed the fundon/09_05_should_be_bound_to_the_correct_object branch from 491a058 to 017e89f Compare September 5, 2024 14:46
@graphite-app graphite-app bot merged commit 017e89f into canary Sep 5, 2024
38 checks passed
@graphite-app graphite-app bot deleted the fundon/09_05_should_be_bound_to_the_correct_object branch September 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants