Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove joined workspace icon from current worksapce card #8117

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Sep 5, 2024

close PD-1669

Copy link
Member Author

JimmFly commented Sep 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Sep 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Sep 5, 2024

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.36%. Comparing base (017e89f) to head (8be67dc).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...onents/workspace-selector/workspace-card/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8117      +/-   ##
==========================================
- Coverage   52.43%   52.36%   -0.08%     
==========================================
  Files        1230     1230              
  Lines       48361    48361              
  Branches     5907     5906       -1     
==========================================
- Hits        25360    25324      -36     
- Misses      22621    22662      +41     
+ Partials      380      375       -5     
Flag Coverage Δ
server-test 77.24% <ø> (-0.08%) ⬇️
unittest 25.17% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly marked this pull request as ready for review September 5, 2024 09:43
@JimmFly JimmFly force-pushed the jimmfly/0905/chore-icon branch 2 times, most recently from 1efd99f to 110fc8a Compare September 5, 2024 10:29
@JimmFly JimmFly requested a review from pengx17 September 5, 2024 13:59
Copy link

graphite-app bot commented Sep 5, 2024

Merge activity

@graphite-app graphite-app bot merged commit 8be67dc into canary Sep 5, 2024
39 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0905/chore-icon branch September 5, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants