Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): journal button should not show for edgeless #8110

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 5, 2024

No description provided.

Copy link

graphite-app bot commented Sep 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Sep 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review September 5, 2024 07:13
Copy link

nx-cloud bot commented Sep 5, 2024

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.44%. Comparing base (2a2a969) to head (d5ecf50).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8110      +/-   ##
==========================================
+ Coverage   52.39%   52.44%   +0.04%     
==========================================
  Files        1230     1230              
  Lines       48340    48340              
  Branches     5904     5905       +1     
==========================================
+ Hits        25327    25351      +24     
+ Misses      22638    22614      -24     
  Partials      375      375              
Flag Coverage Δ
server-test 77.35% <ø> (+0.07%) ⬆️
unittest 25.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Sep 5, 2024

Merge activity

@pengx17 pengx17 force-pushed the 09-05-feat_mobile_add_share_button branch from 7550da2 to 2a2a969 Compare September 5, 2024 09:16
@pengx17 pengx17 force-pushed the 09-05-fix_mobile_journal_button_should_not_show_for_edgeless branch from efb3ee5 to d5ecf50 Compare September 5, 2024 09:17
Base automatically changed from 09-05-feat_mobile_add_share_button to canary September 5, 2024 09:30
@graphite-app graphite-app bot merged commit d5ecf50 into canary Sep 5, 2024
38 checks passed
@graphite-app graphite-app bot deleted the 09-05-fix_mobile_journal_button_should_not_show_for_edgeless branch September 5, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants