Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): selector for editorSetting hooks #8108

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Sep 5, 2024

No description provided.

@EYHN EYHN marked this pull request as ready for review September 5, 2024 06:56
Copy link
Member Author

EYHN commented Sep 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 5, 2024

@EYHN EYHN requested a review from akumatus September 5, 2024 06:57
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (3837c84) to head (691bfed).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...re/src/components/affine/page-properties/table.tsx 0.00% 3 Missing ⚠️
...nents/blocksuite/block-suite-editor/lit-adaper.tsx 0.00% 3 Missing ⚠️
...ore/src/modules/peek-view/view/modal-container.tsx 0.00% 2 Missing ⚠️
...ges/frontend/core/src/providers/modal-provider.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8108      +/-   ##
==========================================
- Coverage   52.44%   52.43%   -0.02%     
==========================================
  Files        1230     1230              
  Lines       48336    48340       +4     
  Branches     5905     5905              
==========================================
- Hits        25351    25346       -5     
- Misses      22610    22619       +9     
  Partials      375      375              
Flag Coverage Δ
server-test 77.35% <ø> (ø)
unittest 25.16% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Sep 5, 2024

Merge activity

Copy link

graphite-app bot commented Sep 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants