feat(core): observe editor settings change and update edgeless editor #8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akumatus
commented
Sep 5, 2024
•
akumatus
commented
🎥 Video uploaded on Graphite:
graphite-app
bot
requested review from
EYHN,
forehalo,
pengx17,
JimmFly and
CatsJuice
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 19a7d1e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
akumatus
requested review from
doouding
and removed request for
CatsJuice and
forehalo
pengx17
reviewed
Sep 5, 2024
...ontend/core/src/components/affine/setting-modal/general-setting/editor/edgeless/snapshot.tsx
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #8105 +/- ##
==========================================
- Coverage 52.47% 52.40% -0.07%
==========================================
Files 1230 1230
Lines 48278 48306 +28
Branches 5887 5891 +4
==========================================
- Hits 25332 25317 -15
- Misses 22571 22614 +43
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akumatus
force-pushed
the
feat/update-editor-when-settings-change
branch
from
546b5c3
to
b2c5ca3
Compare
pengx17
approved these changes
Sep 5, 2024
Merge activity
|
…#8105) <div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/sJGviKxfE3Ap685cl5bj/cfdd0578-274c-42e3-9ef5-5528e8b25306.mov"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/sJGviKxfE3Ap685cl5bj/cfdd0578-274c-42e3-9ef5-5528e8b25306.mov"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/sJGviKxfE3Ap685cl5bj/cfdd0578-274c-42e3-9ef5-5528e8b25306.mov">录屏2024-09-05 14.32.41.mov</video>
akumatus
force-pushed
the
feat/update-editor-when-settings-change
branch
from
b2c5ca3
to
19a7d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.