Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): temporarily add page mode editor settings to appearance settings #8090

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Sep 4, 2024

Will remove it when editor settings is released.

CleanShot 2024-09-04 at 18 19 29@2x

Copy link

graphite-app bot commented Sep 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review September 4, 2024 10:18
Copy link
Member Author

JimmFly commented Sep 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 4, 2024

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 52.44%. Comparing base (059030f) to head (3837c84).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...fine/setting-modal/general-setting/editor/utils.ts 8.33% 11 Missing ⚠️
...ting-modal/general-setting/editor/edgeless/pen.tsx 0.00% 4 Missing ⚠️
...odal/general-setting/editor/edgeless/connector.tsx 0.00% 2 Missing ⚠️
...ing-modal/general-setting/editor/edgeless/note.tsx 0.00% 2 Missing ⚠️
...ing-modal/general-setting/editor/edgeless/text.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8090      +/-   ##
==========================================
+ Coverage   52.43%   52.44%   +0.01%     
==========================================
  Files        1229     1230       +1     
  Lines       48318    48336      +18     
  Branches     5899     5905       +6     
==========================================
+ Hits        25334    25351      +17     
- Misses      22609    22610       +1     
  Partials      375      375              
Flag Coverage Δ
server-test 77.35% <ø> (+0.03%) ⬆️
unittest 25.17% <4.54%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Sep 5, 2024

Merge activity

@JimmFly JimmFly force-pushed the jimmfly/0904/editor-setting branch 2 times, most recently from 5c53124 to 92790c2 Compare September 5, 2024 07:03
@graphite-app graphite-app bot merged commit 3837c84 into canary Sep 5, 2024
38 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0904/editor-setting branch September 5, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants