Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): use CTRL+= to zoom in on windows #8081

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 4, 2024

fix AF-1291

Copy link

graphite-app bot commented Sep 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Sep 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Sep 4, 2024
@pengx17 pengx17 marked this pull request as ready for review September 4, 2024 03:56
Copy link

nx-cloud bot commented Sep 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 01e6370. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@forehalo forehalo changed the title fix(electron): CTRL+= to zoom in on windows fix(electron): use CTRL+= to zoom in on windows Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.66%. Comparing base (2ac803c) to head (01e6370).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8081      +/-   ##
==========================================
+ Coverage   52.62%   52.66%   +0.03%     
==========================================
  Files        1228     1228              
  Lines       48083    48083              
  Branches     5862     5862              
==========================================
+ Hits        25302    25321      +19     
+ Misses      22410    22388      -22     
- Partials      371      374       +3     
Flag Coverage Δ
server-test 77.35% <ø> (ø)
unittest 25.31% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Sep 4, 2024

Merge activity

  • Sep 4, 12:23 AM EDT: forehalo added this pull request to the Graphite merge queue.
  • Sep 4, 12:35 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Unit Test', 'Desktop Test (macos-14, macos, arm64, aarch64-apple-darwin, true)').
  • Sep 4, 2:15 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Sep 4, 2:15 AM EDT: pengx17 merged this pull request with the Graphite merge queue.

@forehalo forehalo force-pushed the 09-04-fix_electron_ctrl_to_zoom_in_on_windows branch from 2931d9e to 01e6370 Compare September 4, 2024 04:23
@graphite-app graphite-app bot merged commit 01e6370 into canary Sep 4, 2024
38 checks passed
@graphite-app graphite-app bot deleted the 09-04-fix_electron_ctrl_to_zoom_in_on_windows branch September 4, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants