fix(core): fix menu bugs

[EYHN]

No description provided.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[EYHN]

• fix(core): fix menu bugs #8074 👈
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 51f3566. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx test:coverage @affine/monorepo
• nx build @affine/native -- --target x86_64-pc-windows-msvc --use-napi-cross
• nx build @affine/server-native -- --target x86_64-unknown-linux-gnu --use-napi-cross
• nx build @affine/native -- --target x86_64-apple-darwin --use-napi-cross
• nx build @affine/native -- --target aarch64-apple-darwin --use-napi-cross
• nx build @affine/native -- --target x86_64-unknown-linux-gnu --use-napi-cross

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Attention: Patch coverage is 35.21127% with 46 lines in your changes missing coverage. Please review.

Project coverage is 52.65%. Comparing base (01e6370) to head (51f3566).
Report is 1 commits behind head on canary.

Files with missing lines	Patch %	Lines
...ontend/component/src/ui/menu/desktop/controller.ts	5.40%	35 Missing ⚠️
...ges/frontend/component/src/hooks/use-ref-effect.ts	78.57%	2 Missing and 4 partials ⚠️
...s/frontend/component/src/hooks/focus-and-select.ts	0.00%	2 Missing ⚠️
...frontend/component/src/ui/editable/inline-edit.tsx	0.00%	1 Missing ⚠️
...ges/frontend/component/src/ui/menu/desktop/sub.tsx	0.00%	1 Missing ⚠️
...tend/core/src/modules/explorer/views/tree/node.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           canary    #8074      +/-   ##
==========================================
- Coverage   52.66%   52.65%   -0.02%     
==========================================
  Files        1228     1229       +1     
  Lines       48083    48110      +27     
  Branches     5862     5870       +8     
==========================================
+ Hits        25321    25330       +9     
- Misses      22388    22406      +18     
  Partials      374      374              

Flag	Coverage Δ
server-test	77.35% <ø> (ø)
unittest	25.32% <35.21%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pengx17]

I like it, but maybe https://github.com/jantimon/react-use-ref-effect/blob/master/src/index.tsx is also cool?

[graphite-app]

Merge activity

• Sep 4, 1:55 AM EDT: EYHN added this pull request to the Graphite merge queue.
• Sep 4, 2:07 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Desktop Test (macos-14, macos, arm64, aarch64-apple-darwin, true)').
• Sep 4, 3:06 AM EDT: EYHN added this pull request to the Graphite merge queue.
• Sep 4, 3:30 AM EDT: EYHN merged this pull request with the Graphite merge queue.