Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): nested modal view-transition support #8073

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Sep 3, 2024

🎥 Video uploaded on Graphite:

Copy link

graphite-app bot commented Sep 3, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Sep 3, 2024

@CatsJuice CatsJuice marked this pull request as ready for review September 3, 2024 11:02
Copy link

nx-cloud bot commented Sep 3, 2024

@CatsJuice CatsJuice force-pushed the catsjuice/fix/component-storybook-theme branch from 31158c9 to f99233b Compare September 3, 2024 11:05
@CatsJuice CatsJuice force-pushed the catsjuice/fix/multiple-modal-view-transition branch from 7cc2b79 to 055ece8 Compare September 3, 2024 11:05
Copy link
Member

@forehalo forehalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bow

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.62%. Comparing base (ec3b97d) to head (0d6f468).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/frontend/component/src/ui/modal/modal.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8073      +/-   ##
==========================================
+ Coverage   52.59%   52.62%   +0.02%     
==========================================
  Files        1228     1228              
  Lines       48080    48083       +3     
  Branches     5860     5862       +2     
==========================================
+ Hits        25289    25303      +14     
+ Misses      22420    22409      -11     
  Partials      371      371              
Flag Coverage Δ
server-test 77.35% <ø> (+0.07%) ⬆️
unittest 25.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn changed the base branch from catsjuice/fix/component-storybook-theme to graphite-base/8073 September 3, 2024 15:18
@Brooooooklyn Brooooooklyn force-pushed the catsjuice/fix/multiple-modal-view-transition branch from 055ece8 to 56e748e Compare September 3, 2024 15:34
@Brooooooklyn Brooooooklyn changed the base branch from graphite-base/8073 to canary September 3, 2024 15:35
@Brooooooklyn Brooooooklyn force-pushed the catsjuice/fix/multiple-modal-view-transition branch from 56e748e to 76690c9 Compare September 3, 2024 15:35
Copy link

graphite-app bot commented Sep 4, 2024

Merge activity

@CatsJuice CatsJuice force-pushed the catsjuice/fix/multiple-modal-view-transition branch from 76690c9 to 0d6f468 Compare September 4, 2024 01:29
@graphite-app graphite-app bot merged commit 0d6f468 into canary Sep 4, 2024
38 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/multiple-modal-view-transition branch September 4, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants