Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): edit tag should not jump to its detail #8070

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 3, 2024

fix AF-1324

Copy link

graphite-app bot commented Sep 3, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Sep 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review September 3, 2024 10:37
Copy link

nx-cloud bot commented Sep 3, 2024

@pengx17 pengx17 force-pushed the 09-03-fix_core_edit_tag_should_not_jump_to_its_detail branch from 0a8e087 to 6004fe3 Compare September 3, 2024 10:42
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.56%. Comparing base (1cac2f6) to head (b680c18).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...d/core/src/components/page-list/operation-cell.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8070      +/-   ##
==========================================
- Coverage   52.60%   52.56%   -0.05%     
==========================================
  Files        1228     1228              
  Lines       48200    48201       +1     
  Branches     5876     5876              
==========================================
- Hits        25355    25336      -19     
- Misses      22466    22491      +25     
+ Partials      379      374       -5     
Flag Coverage Δ
server-test 77.35% <ø> (ø)
unittest 25.27% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly
Copy link
Member

JimmFly commented Sep 3, 2024

It looks like the z-index of this modal is wrong.
CleanShot 2024-09-03 at 19 01 09@2x

Copy link
Collaborator Author

pengx17 commented Sep 5, 2024

It looks like the z-index of this modal is wrong.
CleanShot 2024-09-03 at 19 01 09@2x

I think this is caused by other issues

Copy link

graphite-app bot commented Sep 5, 2024

Merge activity

@pengx17 pengx17 force-pushed the 09-03-fix_core_edit_tag_should_not_jump_to_its_detail branch from 6004fe3 to b680c18 Compare September 5, 2024 02:46
@graphite-app graphite-app bot merged commit b680c18 into canary Sep 5, 2024
38 checks passed
@graphite-app graphite-app bot deleted the 09-03-fix_core_edit_tag_should_not_jump_to_its_detail branch September 5, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants