Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add journal navigation tracking #8046

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 2, 2024

fix AF-1314

Copy link

graphite-app bot commented Sep 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Sep 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review September 2, 2024 08:44
Copy link

nx-cloud bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.60%. Comparing base (06552a1) to head (1cac2f6).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ore/src/components/affine/reference-link/index.tsx 0.00% 3 Missing ⚠️
packages/frontend/core/src/hooks/use-journal.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8046      +/-   ##
==========================================
+ Coverage   52.58%   52.60%   +0.02%     
==========================================
  Files        1228     1228              
  Lines       48196    48200       +4     
  Branches     5875     5876       +1     
==========================================
+ Hits        25342    25355      +13     
+ Misses      22480    22466      -14     
- Partials      374      379       +5     
Flag Coverage Δ
server-test 77.35% <ø> (ø)
unittest 25.35% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 09-02-chore_core_add_journal_open_event branch from 6603a3b to 418a55d Compare September 2, 2024 10:03
@pengx17 pengx17 force-pushed the 09-02-chore_core_add_journal_open_event branch 3 times, most recently from 3ffe16d to b00d6ee Compare September 3, 2024 10:24
Copy link

graphite-app bot commented Sep 3, 2024

Merge activity

  • Sep 3, 6:38 AM EDT: forehalo added this pull request to the Graphite merge queue.
  • Sep 3, 7:21 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Unit Test').
  • Sep 4, 2:15 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Sep 4, 2:26 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Lint', 'E2E Mobile Test (2)', 'Build AFFiNE native (x86_64-apple-darwin)', 'Build AFFiNE native (aarch64-apple-darwin)').
  • Sep 4, 10:26 PM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Sep 4, 10:44 PM EDT: pengx17 merged this pull request with the Graphite merge queue.

forehalo pushed a commit that referenced this pull request Sep 3, 2024
@forehalo forehalo force-pushed the 09-02-chore_core_add_journal_open_event branch from b00d6ee to 3fc9290 Compare September 3, 2024 11:09
pengx17 added a commit that referenced this pull request Sep 4, 2024
@pengx17 pengx17 force-pushed the 09-02-chore_core_add_journal_open_event branch from 3fc9290 to 2538426 Compare September 4, 2024 06:16
@pengx17 pengx17 changed the title chore(core): add journal open event feat(core): add journal navigation tracking Sep 5, 2024
pengx17 added a commit that referenced this pull request Sep 5, 2024
@pengx17 pengx17 force-pushed the 09-02-chore_core_add_journal_open_event branch from 2538426 to f19ab2c Compare September 5, 2024 02:13
@pengx17 pengx17 force-pushed the 09-02-chore_core_add_journal_open_event branch from f19ab2c to 1cac2f6 Compare September 5, 2024 02:32
@graphite-app graphite-app bot merged commit 1cac2f6 into canary Sep 5, 2024
38 checks passed
@graphite-app graphite-app bot deleted the 09-02-chore_core_add_journal_open_event branch September 5, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants