Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): app updater #8043

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix(electron): app updater #8043

merged 1 commit into from
Sep 2, 2024

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Sep 2, 2024

No description provided.

Copy link

graphite-app bot commented Sep 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the app:electron Related to electron app label Sep 2, 2024
Copy link
Member Author

forehalo commented Sep 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 52.78%. Comparing base (a802dc4) to head (d9cedf8).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...lectron/src/main/updater/affine-update-provider.ts 64.28% 8 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8043      +/-   ##
==========================================
+ Coverage   52.76%   52.78%   +0.02%     
==========================================
  Files        1209     1209              
  Lines       47852    47794      -58     
  Branches     5815     5794      -21     
==========================================
- Hits        25247    25227      -20     
+ Misses      22225    22193      -32     
+ Partials      380      374       -6     
Flag Coverage Δ
server-test 77.65% <ø> (ø)
unittest 25.70% <64.28%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo force-pushed the 61/fix-client-updater branch 2 times, most recently from 6f4a625 to 5795074 Compare September 2, 2024 07:31
Copy link

graphite-app bot commented Sep 2, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants