Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(auth): authenticate user in main window #8032

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

forehalo
Copy link
Member

No description provided.

@graphite-app graphite-app bot requested review from EYHN, pengx17, JimmFly and CatsJuice and removed request for EYHN August 30, 2024 12:34
Copy link

graphite-app bot commented Aug 30, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

forehalo commented Aug 30, 2024

Copy link

nx-cloud bot commented Aug 30, 2024

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 11.26761% with 63 lines in your changes missing coverage. Please review.

Project coverage is 52.53%. Comparing base (e33aa35) to head (52c9da6).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...frontend/core/src/components/affine/auth/index.tsx 0.00% 34 Missing ⚠️
packages/frontend/core/src/router.tsx 0.00% 6 Missing ⚠️
...s/frontend/core/src/modules/cloud/services/auth.ts 0.00% 5 Missing ⚠️
...frontend/core/src/components/affine/auth/oauth.tsx 0.00% 4 Missing ⚠️
...ontend/core/src/components/affine/auth/sign-in.tsx 20.00% 4 Missing ⚠️
...c/components/affine/auth/sign-in-with-password.tsx 25.00% 3 Missing ⚠️
...omponents/affine/auth/after-sign-in-send-email.tsx 0.00% 2 Missing ⚠️
packages/frontend/core/src/pages/auth/sign-in.tsx 0.00% 2 Missing ⚠️
...omponents/affine/auth/after-sign-up-send-email.tsx 50.00% 1 Missing ⚠️
...end/core/src/components/affine/auth/send-email.tsx 80.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8032   +/-   ##
=======================================
  Coverage   52.52%   52.53%           
=======================================
  Files        1221     1221           
  Lines       47768    47755   -13     
  Branches     5858     5858           
=======================================
- Hits        25091    25088    -3     
+ Misses      22305    22295   -10     
  Partials      372      372           
Flag Coverage Δ
server-test 77.48% <ø> (ø)
unittest 25.26% <11.26%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

perfsee bot commented Aug 30, 2024

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     canary …n-main-window                 +/- ##
===================================================================
< Bundle              22.3 MB        22.3 MB    +1.36 kB(+0.01%)   
> Initial JS          9.98 MB        9.98 MB      -571 B(-0.01%)   
< Initial CSS          218 kB         218 kB       +83 B(+0.04%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   57             58                  +1   
< Chunks                   55             56                  +1   
= Packages                291            291                       
= Duplicates               23             23                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Improve page load speed with `preconnect` or `dns-prefetch`      
! Avoid cache wasting                                              

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please filter out sign-in failed errors when apis?.ui.isActiveTab returns false

@forehalo forehalo force-pushed the 61/authenticate-in-main-window branch from 3228592 to 7cc6149 Compare September 3, 2024 04:39
Copy link

graphite-app bot commented Sep 3, 2024

Merge activity

@forehalo forehalo force-pushed the 61/authenticate-in-main-window branch from 7cc6149 to 52c9da6 Compare September 3, 2024 09:05
Base automatically changed from 61/auth-client to canary September 3, 2024 09:16
@graphite-app graphite-app bot merged commit 52c9da6 into canary Sep 3, 2024
37 of 38 checks passed
@graphite-app graphite-app bot deleted the 61/authenticate-in-main-window branch September 3, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:i18n Related to i18n mod:store
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants