Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add mobile edit button #7996

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Aug 28, 2024

What changes

  • add mobile edit button in more menu
  • show page properties table and bi-direction panel in readonly mode for mobile

Copy link

graphite-app bot commented Aug 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Aug 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 28, 2024

@L-Sun L-Sun marked this pull request as ready for review August 28, 2024 03:34
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.20%. Comparing base (65a8719) to head (14cca61).
Report is 1 commits behind head on canary.

Files Patch % Lines
...re/src/components/affine/page-properties/table.tsx 0.00% 1 Missing ⚠️
...nents/blocksuite/block-suite-editor/lit-adaper.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7996      +/-   ##
==========================================
- Coverage   55.24%   55.20%   -0.05%     
==========================================
  Files        1060     1060              
  Lines       44752    44752              
  Branches     5277     5276       -1     
==========================================
- Hits        24724    24705      -19     
- Misses      19647    19666      +19     
  Partials      381      381              
Flag Coverage Δ
server-test 77.60% <ø> (-0.08%) ⬇️
unittest 27.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun force-pushed the l-sun/fix/add-mobile-edit-button branch from 549abe5 to 2bfe1e3 Compare August 28, 2024 03:41
@L-Sun L-Sun added merge and removed app:core labels Aug 28, 2024
Copy link

graphite-app bot commented Aug 28, 2024

Merge activity

  • Aug 28, 2:27 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 28, 2:27 AM EDT: L-Sun added this pull request to the Graphite merge queue.

### What changes
- add mobile edit button in more menu
- show page properties table and bi-direction panel in readonly mode for mobile
@L-Sun L-Sun force-pushed the l-sun/fix/add-mobile-edit-button branch from 2bfe1e3 to 14cca61 Compare August 28, 2024 06:27
@L-Sun L-Sun removed the merge label Aug 28, 2024
@forehalo forehalo enabled auto-merge (squash) August 28, 2024 06:34
@forehalo forehalo merged commit 0668568 into canary Aug 28, 2024
34 checks passed
@forehalo forehalo deleted the l-sun/fix/add-mobile-edit-button branch August 28, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants