Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): move fontFamily and fullWidthLayout to editor settings #7988

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Aug 27, 2024

No description provided.

Copy link

graphite-app bot commented Aug 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Aug 27, 2024

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 55.26%. Comparing base (3e810eb) to head (03b2cda).
Report is 4 commits behind head on canary.

Files Patch % Lines
...ges/frontend/core/src/commands/affine-settings.tsx 0.00% 11 Missing ⚠️
...ore/src/modules/peek-view/view/modal-container.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7988      +/-   ##
==========================================
- Coverage   55.27%   55.26%   -0.01%     
==========================================
  Files        1060     1060              
  Lines       44730    44733       +3     
  Branches     5274     5274              
==========================================
- Hits        24724    24723       -1     
- Misses      19625    19629       +4     
  Partials      381      381              
Flag Coverage Δ
server-test 77.68% <ø> (ø)
unittest 27.13% <7.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0827/adjust-font-settings branch from 44f8ccd to e33379b Compare August 27, 2024 08:15
@github-actions github-actions bot added the test Related to test cases label Aug 27, 2024
@JimmFly JimmFly requested a review from akumatus August 27, 2024 09:20
@JimmFly JimmFly force-pushed the jimmfly/0827/adjust-font-settings branch from e33379b to e5fd179 Compare August 27, 2024 15:48
Copy link

graphite-app bot commented Aug 28, 2024

Merge activity

@EYHN EYHN force-pushed the jimmfly/0827/adjust-font-settings branch from e5fd179 to 03b2cda Compare August 28, 2024 02:35
@graphite-app graphite-app bot merged commit 03b2cda into canary Aug 28, 2024
33 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0827/adjust-font-settings branch August 28, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants