Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): no share page in desktop #7983

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Aug 27, 2024

No description provided.

@EYHN EYHN marked this pull request as ready for review August 27, 2024 03:01
Copy link

graphite-app bot commented Aug 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Aug 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link

nx-cloud bot commented Aug 27, 2024

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.27%. Comparing base (b8f07ce) to head (3e810eb).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7983      +/-   ##
==========================================
+ Coverage   55.23%   55.27%   +0.04%     
==========================================
  Files        1060     1060              
  Lines       44730    44730              
  Branches     5273     5274       +1     
==========================================
+ Hits        24705    24724      +19     
+ Misses      19644    19625      -19     
  Partials      381      381              
Flag Coverage Δ
server-test 77.68% <ø> (+0.07%) ⬆️
unittest 27.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 27, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/fix/shared-page-in-desktop branch from 6aa0175 to 3e810eb Compare August 27, 2024 12:37
@graphite-app graphite-app bot merged commit 3e810eb into canary Aug 27, 2024
33 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/shared-page-in-desktop branch August 27, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants