Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(infra): remove setimmediate #7975

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Aug 26, 2024

No description provided.

Copy link

graphite-app bot commented Aug 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review August 26, 2024 09:47
@github-actions github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app labels Aug 26, 2024
Copy link
Member Author

EYHN commented Aug 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 26, 2024

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.27%. Comparing base (611925f) to head (9ea4aaa).
Report is 1 commits behind head on canary.

Files Patch % Lines
packages/common/infra/src/livedata/effect/index.ts 0.00% 3 Missing ⚠️
...ckages/common/infra/src/framework/core/provider.ts 0.00% 1 Missing ⚠️
packages/common/infra/src/livedata/livedata.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7975   +/-   ##
=======================================
  Coverage   55.27%   55.27%           
=======================================
  Files        1060     1060           
  Lines       44725    44725           
  Branches     5272     5272           
=======================================
  Hits        24722    24722           
  Misses      19624    19624           
  Partials      379      379           
Flag Coverage Δ
server-test 77.68% <ø> (ø)
unittest 27.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 26, 2024

Merge activity

@graphite-app graphite-app bot merged commit 9ea4aaa into canary Aug 26, 2024
33 checks passed
@graphite-app graphite-app bot deleted the eyhn/remove/setimmediate branch August 26, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants